Re: [ecasound] Bug: -i:resample and -y

From: Kai Vehmanen <kvehmanen@email-addr-hidden>
Date: Wed Mar 24 2010 - 22:24:58 EET

Hi,

On Mon, 22 Mar 2010, Artur wrote:

[bug with '-y' and resample]
> The patch below fixes the bug, though I'm not sure whether it is done
> properly (on the other hand - it looks pretty ;)).

thanks, this is indeed a bug in ecasound. I've now fixed this
with commit:
http://ecasound.git.sourceforge.net/git/gitweb.cgi?p=ecasound/ecasound;a=commit;h=c6125787c5fc6e6a345cbd67e86aa855df7f8857

Basicly your patch:

> --- libecasound/audioio-resample.cpp.orig 2009-03-23 07:49:21.000000000 +0100
> +++ libecasound/audioio-resample.cpp 2010-03-22 13:20:27.560851180 +0100
> @@ -264,6 +264,7 @@
>
> SAMPLE_SPECS::sample_pos_t AUDIO_IO_RESAMPLE::seek_position(SAMPLE_SPECS::sample_pos_t pos)
> {
> + recalculate_psfactor();
> SAMPLE_SPECS::sample_pos_t pub_pos, child_pos =
> static_cast<long int>(std::floor(pos * (1.0f / psfactor_rep)));

... is correct, but the actual bug happens already in open() (invalid
value is assigned psfactor_rep).

------------------------------------------------------------------------------
Download Intel&#174; Parallel Studio Eval
Try the new software tools for yourself. Speed compiling, find bugs
proactively, and fine-tune applications for parallel performance.
See why Intel Parallel Studio got high marks during beta.
http://p.sf.net/sfu/intel-sw-dev
_______________________________________________
Ecasound-list mailing list
Ecasound-list@email-addr-hidden
https://lists.sourceforge.net/lists/listinfo/ecasound-list
Received on Thu Mar 25 00:15:03 2010

This archive was generated by hypermail 2.1.8 : Thu Mar 25 2010 - 00:15:03 EET