Subject: Re: [ecasound] ecasound 2.3.0 mp3 header problem
From: Julian Dobson (juliand_AT_braverock.com)
Date: Mon Nov 17 2003 - 21:49:20 EET
I never said it was pretty :)
I'll attempt to find an example (I don't recall which files gave the
problem now, so I need to compile an unpatched version and run some
tests). I'll drop them too you as soon as possible.
Julian
Kai Vehmanen wrote:
> On Thu, 25 Sep 2003, Julian Dobson wrote:
>
>
>>As promised, here is the patch for libecasound/audioio-mp3.cpp... On
>>review it's not perfect as it skips a block into the file for the second
>>header check and if it doesn't find a second header there, it starts
>>looking for headers from that point, when really it should go back to
>>where it found the first header to continue looking. However, I've yet
>>to find an mp3 it fails on (unlike the orginal code).
>
>
> The patch looks pretty good, but contains a few critical things that need
> to fixed before commit to CVS:
> - leaks memeory ('buf' is not freed in all cases)
> - goto-usage; the code would be cleaner with out it :)
>
> Hmm, could you provide me an mp3 that fails with the current 2.3.0 code? I
> could take a look at modifying the patch, but it would be good to have
> something to test against.
>
This archive was generated by hypermail 2b28 : Mon Nov 17 2003 - 21:45:43 EET