Subject: Re: [ecasound] ecasound 2.3.0 mp3 header problem
From: Kai Vehmanen (k_AT_eca.cx)
Date: Thu Sep 25 2003 - 04:11:59 EEST
On Wed, 3 Sep 2003, Julian Dobson wrote:
> On investigation, it turned out that while the code had been updated to
> search the whole file for a header, the code checked for a second header
> incorrectly. Specifically, the first header is found inside a loop while
> the second header is found outside the loop. In my particular situation,
> the id3v2 tags appear to fake a header, so the second check fails.
[...]
> The solution was to move the second check inside the loop, so the loop
> only exits after two consecutive good frame headers.
[...]
> If anyone would like to look over the code, please let me know and I can
> post it to the list.
Great, I'd be definitely interested in the fixes! The mp3 header parsing
code is originally from XMMS-1.2.5. I haven't been following the XMMS
codebase, so there might indeed be some bugs... (possibly already fixed in
XMMS).
-- http://www.eca.cx Audio software for Linux!
This archive was generated by hypermail 2b28 : Thu Sep 25 2003 - 04:16:37 EEST