Absent initialisation in audiofx_reverb.cpp causes noise at startup!

New Message Reply About this list Date view Thread view Subject view Author view Other groups

Subject: Absent initialisation in audiofx_reverb.cpp causes noise at startup!
From: Hans-Georg Fischer (hg.liste_AT_snafu.de)
Date: Sat Dec 07 2002 - 21:29:39 EET

Hallo,

using -ete produces noise at startup because oldvalue and lpvalue are
not propper initialised in audiofx_reverb.cpp. The little patch I
included below corrects this I think.

--- ecasound-2.0.4/libecasound/audiofx_reverb.cpp Sun Jul 23 13:16:37 2000
+++ ecasound-2.0.4_corr/libecasound/audiofx_reverb.cpp Sat Dec 7 20:15:33 2002
@@ -64,6 +64,8 @@
   if (param == 1 || param == 2) {
     vector<CHANNEL_DATA>::iterator p = cdata.begin();
     while(p != cdata.end()) {
+ p->oldvalue=0.0;
+ p->lpvalue=0.0;
       p->dpos[0] = static_cast<long int>(roomsize_rep * srate_rep / 333);
       p->mul[0] = 0.035;
       p->bufferpos_rep = 0;
@@ -82,6 +84,8 @@
   cdata.resize(insample->number_of_channels());
   vector<CHANNEL_DATA>::iterator p = cdata.begin();
   while(p != cdata.end()) {
+ p->oldvalue=0.0;
+ p->lpvalue=0.0;
     p->dpos[0] = static_cast<long int>(roomsize_rep * srate_rep / 333);
     p->mul[0] = 0.035;
     p->bufferpos_rep = 0; 

-- 

Hans-Georg Fischer

New Message Reply About this list Date view Thread view Subject view Author view Other groups

This archive was generated by hypermail 2b28 : Sat Dec 07 2002 - 21:24:51 EET